Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024.12 to allowed array API versions #4262

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented Feb 2, 2025

This is a bit pre-emptive: 2024.12 Array API spec is not released yet :-).

However, the story goes like this:

The 2024.12 release is in the works and is expected "soon" (tm);
We would like to release array-api-compat and array-api-strict with 2024.12 support quickly once the spec itself is finalized;
Testing of array-api-compat across Array API provider libraries (numpy, pytorch, jax.numpy, dask) relies on array-api-tests;
array-api-tests relies on hypothesis.extra.array_api module;
if hypothesis.extra.array_api does not recognize 2024.12 as an allowed version, we cannot even start testing anything against the new spec version.

So I'm wondering what would you think about merging this one-line change and cutting a new hypothesis release? I fully realize it might sound a bit preposterous to ask for a release because of an unrelated change in a far far corner of your userspace. Still I've got to ask :-).

EDIT: now that I actually read the release policy, am adding the RELEASE.rst snippet. I'd guess there's not much need to precisely time this PR: hypothesis full well can recognize an upcoming array API version.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit nervous about shipping this before upstream actually releases the standard, but I think it's worth avoiding awkward monkeypatches in the ecosystem and we don't need to make any substantive changes for updates anyway (cf #3901).

Thanks for the PR and your work on the array api standard, @ev-br!

@Zac-HD Zac-HD merged commit b53d68c into HypothesisWorks:master Feb 3, 2025
50 checks passed
@ev-br
Copy link
Contributor Author

ev-br commented Feb 3, 2025

Wow, I did not expect this quick turnaround. Thank you @Zac-HD for the merge and for the hypothesis itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants