Add type hints to strategies.py
#4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
commented
Feb 1, 2025
Comment on lines
+270
to
+272
| @property | ||
| def has_reusable_values(self) -> Any: | ||
| return recursive_property(self, "has_reusable_values", True) |
There was a problem hiding this comment.
using explicit @property for mypyc, but I think it's also cleaner
Zac-HD
reviewed
Feb 2, 2025
Comment on lines
+190
to
+204
| count = 0 | ||
| seen = set() | ||
| while needs_update: | ||
| count += 1 | ||
| # If we seem to be taking a really long time to stabilize we | ||
| # start tracking seen values to attempt to detect an infinite | ||
| # loop. This should be impossible, and most code will never | ||
| # hit the count, but having an assertion for it means that | ||
| # testing is easier to debug and we don't just have a hung | ||
| # test. | ||
| # Note: This is actually covered, by test_very_deep_deferral | ||
| # in tests/cover/test_deferred_strategies.py. Unfortunately it | ||
| # runs into a coverage bug. See | ||
| # https://github.com/nedbat/coveragepy/issues/605 | ||
| # for details. |
There was a problem hiding this comment.
A check for an impossible case, which nonetheless has a test, except also a nocover pragma, due to an intractable upstream bug? Classic Hypothesis experience, nothing to see here...
|
I've tacked a bugfix on to this pull and fixed CI errors 👍 |
Zac-HD
approved these changes
Feb 3, 2025
hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.