Default to CI-appropriate settings when running on CI #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
Oct 30, 2024
DRMacIver
force-pushed
the
DRMacIver/ci-config
branch
from
7d21980 to
e8bce25
Compare
DRMacIver
force-pushed
the
DRMacIver/ci-config
branch
from
655a4bb to
13c3785
Compare
|
Phew. Finally a green build. It turns out it's surprisingly hard to make changes to brittle code that affects literally every single test! |
|
Note for later: I'd like it if when people define their own CI profile they could reliably expect it to run on a CI server. This is not, I think, currently the case, because you need to load a profile after registering it. I think if you reregister the currently loaded profile it should automatically load the new one, but I don't want to do it in this PR because it's another change to brittle code. |
Zac-HD
approved these changes
Nov 1, 2024
lazka
added a commit
to lazka/pycairo
that referenced
this pull request
Nov 15, 2024
hypothesis broke API in HypothesisWorks/hypothesis#4152 by changing the documented settings defaults to a different type (it's a good change though) Since the upstream change is trying to make good defaults for CI remove our CI specific settings adjustments and just use the new defaults.
lazka
added a commit
to lazka/mutagen
that referenced
this pull request
Nov 25, 2024
hypothesis broke API in HypothesisWorks/hypothesis#4152 by changing the documented settings defaults to a different type (it's a good change though) Since the upstream change is trying to make good defaults for CI remove our CI specific settings adjustments and just use the new defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one too many complaints about Hypothesis being unsuitable for CI usage, I finally got around to making it so that the trivial configuration for making it deterministic on CI happens out of the box for you. Now if you set the
CIenvironment variable it will run deterministically (as long as your test code is deterministic).