callable-types: add parens inside ArrayType (palantir#3440)

[bugfix] `callable-types` adds parentheses when fixing a type literal inside an array type
HyphnKnight · Apr 9, 2018 · 77d2c1f · 77d2c1f
1 parent 526ca52
commit 77d2c1f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/callableTypesRule.ts b/src/rules/callableTypesRule.ts
@@ -104,6 +104,7 @@ function shouldWrapSuggestion(parent: ts.Node) {
     switch (parent.kind) {
         case ts.SyntaxKind.UnionType:
         case ts.SyntaxKind.IntersectionType:
+        case ts.SyntaxKind.ArrayType:
             return true;
         default:
             return false;

diff --git a/test/rules/callable-types/test.ts.fix b/test/rules/callable-types/test.ts.fix
@@ -17,6 +17,7 @@ function f(x: string | (() => void)): void;
 function f(x: (() => string) | (() => number)): void;
 function f(x: string & (() => void)): void;
 function f(x: (() => string) & (() => number)): void;
+function f(x: (() => string)[]): void;
 
 // Overloads OK
 interface K {
@@ -28,3 +29,4 @@ interface K {
 export type I = () => void;
 
 export type T = () => void
+
diff --git a/test/rules/callable-types/test.ts.lint b/test/rules/callable-types/test.ts.lint
@@ -44,6 +44,8 @@ function f(x: string & { (): void }): void;
 function f(x: { (): string } & { (): number }): void;
                 ~~~~~~~~~~ [type % ('(() => string)')]
                                  ~~~~~~~~~~ [type % ('(() => number)')]
+function f(x: { (): string }[]): void;
+                ~~~~~~~~~~ [type % ('(() => string)')]
 
 // Overloads OK
 interface K {
@@ -64,4 +66,4 @@ export type T = {
 
 [_base]: %s has only a call signature — use `%s` instead.
 [interface]: _base % ('Interface')
-[type]: _base % ('Type literal')
+[type]: _base % ('Type literal')