Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old submissions table related code and removed fancybox #4226

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Nov 25, 2024

Fixes #4224

  • Removed old submissions all table code
  • Removed old submission table batch actions
  • Use htmx for invoice batch status update action

Test Steps

  • All batch actions are working fine for new table.
  • Invoice status batch update is working fine.

@sandeepsajan0 sandeepsajan0 changed the title Remove old submissions table, removed old table batch actions, update… Remove old submissions table related code Nov 25, 2024
@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/remove-old-submission-table branch from db9c1fa to 2caefec Compare November 25, 2024 12:40
@frjo
Copy link
Member

frjo commented Nov 26, 2024

@sandeepsajan0 Added task to remove obsolete CSS, notices that when I created #4230.

@sandeepsajan0
Copy link
Member Author

When I was looking at its failed test(user/test_middleware), I found an interesting issue that is somehow working fine in UI and passed the tests as well.
Actually, this url was added as a particular submission success page that has to be exempted from 2FA so we added it here in middleware but didn't add the submission id as it has to be dynamic. And it is working with middleware/UI because we are checking URLs by using 'startswith' but in the above test we are trying to access the same url without submission id that was unintentionally matching with path 'submissions/<str:status>' and then auth(redirect) and passing the test. As that path has been removed in this PR, test failed so for now I just added a submission and used that submission id to match success url.

But I think for the long-term instead of accessing the url we should only be testing the middleware code to check if it is going through or not? @frjo @theskumar

@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/remove-old-submission-table branch from 0957d1d to 642c2c1 Compare November 29, 2024 11:26
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter labels Dec 3, 2024
@frjo
Copy link
Member

frjo commented Dec 9, 2024

@sandeepsajan0 I have no merged #4188 in to main.

@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/remove-old-submission-table branch from 0482707 to 595d61c Compare December 9, 2024 11:31
@sandeepsajan0 sandeepsajan0 changed the title Remove old submissions table related code Remove old submissions table related code and removed fancybox Dec 9, 2024
@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review December 9, 2024 11:37
@frjo
Copy link
Member

frjo commented Dec 9, 2024

Did some minor lint fixes.

Notices this "+131 −1755", that is a lot of code lines we no longer need to maintain!

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 9, 2024
@frjo
Copy link
Member

frjo commented Dec 9, 2024

@wes-otf I believe @sandeepsajan0 fixed a bug regarding batch actions in the new submission all table as well in this PR.

@wes-otf
Copy link
Contributor

wes-otf commented Dec 13, 2024

seems like all worked pretty well! like @frjo said definitely nice to have that much to not maintain! Regarding the first test step, the only issue I saw with batch updating was I tried to do a batch action of dismissing these 6 and got a server error. @sandeepsajan0 / @frjo if that feels out of scope for this PR I can write up another issue

@wes-otf wes-otf removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 13, 2024
@frjo
Copy link
Member

frjo commented Dec 16, 2024

@wes-otf @sandeepsajan0 The submissions (only three show up on test today with this search) use different determination forms. This makes it impossible to dismiss them together in one batch run.

For status changes that require a determination (Accept, Dismiss and Invite for proposal) the batch status dropdown needs to check that the selected submissions use the same determination form. If easier we can check that they belong to the same round/lab.

The error message is not correct I believe, "Submissions expect different forms - please contact admin". The problem is that the forms are not the same from what I understand.

@frjo frjo merged commit 2f4af90 into main Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the old submission all table
3 participants