-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old submissions table related code and removed fancybox #4226
Conversation
db9c1fa
to
2caefec
Compare
@sandeepsajan0 Added task to remove obsolete CSS, notices that when I created #4230. |
When I was looking at its failed test(user/test_middleware), I found an interesting issue that is somehow working fine in UI and passed the tests as well. But I think for the long-term instead of accessing the url we should only be testing the middleware code to check if it is going through or not? @frjo @theskumar |
0957d1d
to
642c2c1
Compare
@sandeepsajan0 I have no merged #4188 in to main. |
… invoice batch action to use htmx
0482707
to
595d61c
Compare
Did some minor lint fixes. Notices this "+131 −1755", that is a lot of code lines we no longer need to maintain! |
@wes-otf I believe @sandeepsajan0 fixed a bug regarding batch actions in the new submission all table as well in this PR. |
seems like all worked pretty well! like @frjo said definitely nice to have that much to not maintain! Regarding the first test step, the only issue I saw with batch updating was I tried to do a batch action of dismissing these 6 and got a server error. @sandeepsajan0 / @frjo if that feels out of scope for this PR I can write up another issue |
@wes-otf @sandeepsajan0 The submissions (only three show up on test today with this search) use different determination forms. This makes it impossible to dismiss them together in one batch run. For status changes that require a determination (Accept, Dismiss and Invite for proposal) the batch status dropdown needs to check that the selected submissions use the same determination form. If easier we can check that they belong to the same round/lab. The error message is not correct I believe, "Submissions expect different forms - please contact admin". The problem is that the forms are not the same from what I understand. |
Fixes #4224
Test Steps