Skip to content

Commit

Permalink
build: disable NODE_OPTIONS
Browse files Browse the repository at this point in the history
Production binaries shall NOT take NODE_OPTIONS from end-users.

Only the users (developers who use pkg to package their project) should
have control over the flags via the "bake in" (--options) mechanism.

Bug: vercel/pkg#954, vercel/pkg#989, vercel/pkg#1194, vercel/pkg#1517
  • Loading branch information
jesec authored and Hypfer committed May 7, 2022
1 parent 1f4840f commit 624cfb0
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ function getConfigureArgs(major: number, targetPlatform: string): string[] {
}
}

// production binaries do NOT take NODE_OPTIONS from end-users
args.push('--without-node-options');

// DTrace
args.push('--without-dtrace');

Expand Down

0 comments on commit 624cfb0

Please sign in to comment.