Viomi minor bugfixes #820
Viomi minor bugfixes #820
Conversation
| @@ -458,6 +488,11 @@ class ViomiMapParser { | |||
| //Repeated for every room there is | |||
| this.take(unkLength * 2, "room data"); | |||
|
|
|||
| if (this.mapId === 0) { | |||
| // Sometimes the map is truncated here, when that happens the second word is zeroes | |||
There was a problem hiding this comment.
Could these be incremental map updates or do those still contain a full map image etc?
There was a problem hiding this comment.
Nope, it contains everything except the "extended" room data + room outlines.
For some reason this is sent as soon as the robot touches the dock and in no other circumstance.
There was a problem hiding this comment.
Maybe thats when room splitting stuff is recalculated or something like that 🤔
There was a problem hiding this comment.
Indeed I just noticed it wants the same map ID for editing segments. It probably returns map ID set to 0 so that segment editing won't work until it's done.
depau
force-pushed
the
viomi-map-refresh
branch
from
1bb4921 to
04e0e21
Compare
depau
force-pushed
the
viomi-map-refresh
branch
from
04e0e21 to
74aacdd
Compare
|
Since the presigned URL stuff was moved to #873, this can now be reviewed. I dropped the presigned URL stuff from this history. |
depau
force-pushed
the
viomi-map-refresh
branch
from
74aacdd to
3605d9b
Compare
Makes map "presigned URL" payload consistent with how the OEM cloud currently sends itmoved to feat(miio): Unify map presigned URL responses #873