Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/CD] Fix linux and mac builds and releases. Automate flathub releases #411

Merged
merged 22 commits into from
Aug 6, 2023
Merged

[CI/CD] Fix linux and mac builds and releases. Automate flathub releases #411

merged 22 commits into from
Aug 6, 2023

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Jul 14, 2023 •
edited
Loading

  • Revert to png so that icns conversion does not fail dep, rpm, pacman builds
  • Add all builds to ci build workflow so that release builds are assured to build before tagging a release
  • Upgrade electron-builder to latest to get this fix for macos builds fix(mac): Wrap hditutil detach in retry w/ backoff electron-userland/electron-builder#7600
  • fix missing dependency for gh runner to build pacman
  • update to v3 setup-node and upload-artifacts
  • upload each linux build as an artifact
  • automatically generate flathub PR on release published trigger

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Jul 14, 2023
flavioislima
flavioislima reviewed Jul 14, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@BrettCleary
Copy link
Collaborator Author

rebased off main

@BrettCleary
[CI] Automate Flathub Releases (#423)
2648917 
* trigger workflow

* add gha to automate flathub PR

* fix update flathub script name

* fix ref name

* fix working directory

* update publish flathub command

* fix flathub repo

* add commit changes to flathub release

* update git commit action

* publish before commit

* replace commit action

* fixes to flathub gha

* fix gh pr command

* fix download url
@BrettCleary BrettCleary mentioned this pull request Jul 28, 2023
Merged
4 tasks
@BrettCleary
[CI] Flathub Release ci/cd fixes (#429)
f9948f8 
* fix flathub gha

* fix comment use personal repo for test

* add test toggle

* fix top level await

* fixes

* disable test flag
@BrettCleary BrettCleary changed the title [Fix] App icon and linux ci build [Fix] App icon. linux and mac ci builds. automate flathub releases Jul 29, 2023
@BrettCleary BrettCleary changed the title [Fix] App icon. linux and mac ci builds. automate flathub releases [CI/CD] Fix linux and mac builds and releases. Automate flathub releases Jul 29, 2023
flavioislima
flavioislima approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good stuff, can't wait to test it on the next release! 🔥

@BrettCleary BrettCleary merged commit 8833d8e into main Aug 6, 2023
10 checks passed
@BrettCleary BrettCleary deleted the fix/app_icon branch August 6, 2023 21:47
@BrettCleary BrettCleary mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
PR: Ready-For-Review PR is ready to be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @flavioislima