Make multicast functional on Windows #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthespian
force-pushed
the
Fix_windows_multicast
branch
from
379bd6a
to
f787967
Compare
|
The option I will try to write an integration test (based on the current I will merge this pull request, but only publish a new version to pypi when I tried to write a new integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses socket.IPPROTO_IP for group membership functions. I haven't been able to test on other OSes but it appears likely this should work universally. Would need other test platforms to confirm.
Also shortened README.md line 151 comment to eliminate flake warnings
And added multicast leaves to the two examples that included joins, just to illustrate good practice.