#632 Continued: Fuzzy month years logic for time span humanize extensions #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TimeUnit.Year with translations.
…ked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending.
…umanizeExtensions Fuzzy month years logic for time span humanize extensions
Added support for Greek language in resources
akamud
reviewed
May 10, 2017
| @@ -6,6 +6,29 @@ namespace Humanizer.Tests.Localisation.pt | |||
| [UseCulture("pt")] | |||
| public class TimeSpanHumanizeTests | |||
| { | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #632 that @MaStr11 started. It's here to serve as a base branch for other languages to PR into.
Fixes #583
This change now allows calls to
TimeSpanHumanizeExtensions.Humanizewith the parametermaxUnitandminUnitset toTimeUnit.MonthormaxUnit: TimeUnit.Year. The duration in month and years is approximated based on 365.2425 days a year (length of the gregorian calendar). Therefore the month are alternating between 30 and 31 days and the years are alternating between 365 and 366 days.The existing default value for
maxUnit=TimeUnit.Weekis kept because weeks are precise while month and year are not.Most of the changes are related to the translation of the month and year identifiers. All text were translated with google translator except:
I marked the test related to translations with the
[Trait("Translation", "Google")]attribute to make clear which translations are of poor quality.Checklist for the Translation Reviews: