Custom enum description attribute property names #277
Conversation
|
Thanks @mexx. That was quick!! The TC build is broken. Can you check that out please? |
| @@ -98,5 +100,20 @@ public static IDateTimeHumanizeStrategy DateTimeHumanizeStrategy | |||
| get { return _dateTimeHumanizeStrategy; } | |||
| set { _dateTimeHumanizeStrategy = value; } | |||
| } | |||
|
|
|||
| private const string DefaultEnumDescriptionPropertyName = "Description"; | |||
There was a problem hiding this comment.
I am not sure about the implementation. It feels a bit complex. What if we just created a DescriptionPropertyLocator predicate function? Let them keep the logic. This way they can be as flexible as they want!
There was a problem hiding this comment.
I wanted to provide the possibility to have different property names per enum type.
But as already mentioned it a first attempt, so let discuss further the possibilities.
There was a problem hiding this comment.
After a second thought, it would be flexible enough since the PropertyInfo has the reference to the DeclaringType, so even my use case can be implemented with the predicate function.
I'll rewrite it now.
There was a problem hiding this comment.
I am not sure if that level of granular control is necessary to be honest with you. Also remember PropertyInfo is from the attribute not the target enum!
There was a problem hiding this comment.
Maybe we can just expose Func<PropertyInfo, bool>? That way they won't be able to nominate different attributes for different enums but I call YAGNI on it for now.
There was a problem hiding this comment.
Yes, you're right. Func<PropertyInfo, bool> is done.
…roperty-names Custom enum description attribute property names
|
Awesome. Thanks @mexx |
|
Thanks! I will give it a try and provide feedback ... |
|
Not deployed yet. I will let you know as soon as it hits NuGet. On Fri, May 23, 2014 at 6:50 PM, Miguel Moura notifications@github.comwrote:
|
|
This is now released to NuGet as v1.27.0. Thanks for your contribution. |
Resolves #272
any feedback is welcome