Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gender for ToOrdinalWords (needed for Brazilian Portuguese) #196

Merged
merged 6 commits into from
Apr 12, 2014

Conversation

akamud
Copy link
Contributor

@akamud akamud commented Apr 12, 2014

Added pt-br localisation gender for number to words.
Added pt-br localisation for ordinal words, with gender.

@akamud
Copy link
Contributor Author

akamud commented Apr 12, 2014

I also moved the OrdinalTests from English to NumberToWordsTests since ToOrdinalWords is now merged in NumberToWordsExtensions.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Is it safe to review/merge this now? :p

@akamud
Copy link
Contributor Author

akamud commented Apr 12, 2014

Yes. Just updated the readme, I believe it is all set now.

@@ -436,6 +436,16 @@ This is kind of mixing `ToWords` with `Ordinalize`. You can call `ToOrdinalWords
121.ToOrdinalWords() => "hundred and twenty first"
```

`ToOrdinalWords` also supports `GrammaticalGender`, you can pass a second argument to `ToOrdinalWords` to specify which gender the number should be outputted in. The possible values are `GrammaticalGender.Masculine`, `GrammaticalGender.Feminine` and `GrammaticalGender.Neuter`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating the readme :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also explain that this is applicable to some culture only.

@akamud
Copy link
Contributor Author

akamud commented Apr 12, 2014

Updated readme explaining Gender for Ordinal is optional and added an example of pt-br Neutral gender.

@MehdiK MehdiK merged commit 052d702 into Humanizr:master Apr 12, 2014
@akamud akamud deleted the pt-br-towords-ordinal branch April 12, 2014 14:25
@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Merged now. I made a few small changes to the converter and the readme. I would appreciate your review.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This was a great clean PR. Thanks for the great work :)

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is now published to NuGet as v1.21.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants