Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pt-BR NumberToWords localisation #194

Closed
wants to merge 10 commits into from

Conversation

akamud
Copy link
Contributor

@akamud akamud commented Apr 12, 2014

No description provided.

akamud and others added 10 commits April 12, 2014 00:25
…e language Name aswell.

This is needed for languages that can be ambiguous in Two Letter ISO Code (pt-BR, pt-PT both have 'pt' Two Letter ISO code).
…e language Name aswell.

This is needed for languages that can be ambiguous in Two Letter ISO Code (pt-BR, pt-PT both have 'pt' Two Letter ISO code).
…factories.

Better NumerToWordsFactoryTests formatting.
@akamud akamud mentioned this pull request Apr 12, 2014
MehdiK pushed a commit that referenced this pull request Apr 12, 2014

namespace Humanizer.Tests.Localisation
{
public class NumberToWordsFactoryTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this class provides much benefit as everything asserted here is already being tested much more thoroughly elsewhere. So removing it.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is merged now. Thanks a lot for fixing the issues and adding the smarter factory.

I made a few small changes that I'd appreciate if you could review. The commit can be found here.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is now published to NuGet as v1.21.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants