Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bulgarian localization, date and timespan tests #181

Closed
wants to merge 30 commits into from

Conversation

ivanst-stoyanov
Copy link
Contributor

Added Bulgarian localization, date and timespan tests.

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thank god, a PR with no review comments!! Thanks for the clean consistent code and tests.

Please rebase your code on top of the upstream, add your PR to the release notes and force push.

ivanst-stoyanov and others added 28 commits April 12, 2014 11:37
Similar classes exist in System.Web.ModelBinding, which aren't used by
ASP.Net MVC. Users copying and pasting the sample from the readme might
end up using the wrong namespace.
@ivanst-stoyanov
Copy link
Contributor Author

Thank you! It is great to work on this wonderful library. I'll start implementing the NumberToWords functionality.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

I cherry-picked your commit as your rebase had gone bad and your commits were far behind the head. For future contribution please follow the contribution guideline.

Thanks for the work and I am glad you liked the experience.

@MehdiK MehdiK closed this Apr 12, 2014
@MehdiK MehdiK mentioned this pull request Apr 12, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is now published to NuGet as v1.21.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants