Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Slovak localization (strings, formatter, tests) #124

Merged
merged 4 commits into from
Apr 4, 2014
Merged

added Slovak localization (strings, formatter, tests) #124

merged 4 commits into from
Apr 4, 2014

Conversation

igorkulman
Copy link
Contributor

No description provided.

@MehdiK
Copy link
Member

MehdiK commented Apr 3, 2014

Thanks for this. As mentioned in the issue you've raised we will have to fix DateTimeHumanize tests for all locales by extracting the Verify method out of the base DateTimeHumanize tests and apply it to all the DateTime tests. So we need a PR for this that has to go in before this PR.

[InlineData(10, "o 10 sekúnd")]
public void NSecondsFromNow(int number, string expected)
{
var humanize = DateTime.UtcNow.AddSeconds(number).Humanize();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to do one line tests by inlining the calculation and assertions. Please online the humanize in all tests.

@MehdiK
Copy link
Member

MehdiK commented Apr 3, 2014

I need to fix up a few things on DateTime tests; so if you could fix up the review comments, extract the Verify method, clean up the DateTime tests, apply Verify on your tests and push it up.

@igorkulman
Copy link
Contributor Author

I have made the changes

MehdiK added a commit that referenced this pull request Apr 4, 2014
added Slovak localization (strings, formatter, tests)
@MehdiK MehdiK merged commit bd16448 into Humanizr:master Apr 4, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 4, 2014

Thanks for this.

The tests still fail randomly. So I will have to apply the fix soon.

@MehdiK
Copy link
Member

MehdiK commented Apr 6, 2014

The tests were fixed on #131.

This is now released as v1.17.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants