Adjust ByteSize Parse/TryParse exceptions

Humanizr · May 3, 2021 · 94694af · 94694af
1 parent d4972e0
commit 94694af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/Humanizer.Tests.Shared/Bytes/ParsingTests.cs b/src/Humanizer.Tests.Shared/Bytes/ParsingTests.cs
@@ -38,9 +38,10 @@ public void Parse()
         }
 
         [Fact]
-        public void TryParseThrowsOnNull()
+        public void TryParseReturnsFalseOnNull()
         {
-            Assert.Throws<ArgumentNullException>(() => { ByteSize.TryParse(null, out var result); });
+            Assert.False(ByteSize.TryParse(null, out var result));
+            Assert.Equal(default, result);
         }
 
         [Fact]
@@ -93,6 +94,9 @@ public void ParseDecimalMegabytes()
         }
 
         [Theory]
+        [InlineData("")]
+        [InlineData(" ")]
+        [InlineData("\t")]
         [InlineData("Unexpected Value")]
         [InlineData("1000")]
         [InlineData(" 1000 ")]

diff --git a/src/Humanizer/Bytes/ByteSize.cs b/src/Humanizer/Bytes/ByteSize.cs
@@ -478,7 +478,8 @@ public static bool TryParse(string s, IFormatProvider formatProvider, out ByteSi
             // Arg checking
             if (string.IsNullOrWhiteSpace(s))
             {
-                throw new ArgumentNullException(nameof(s), "String is null or whitespace");
+                result = default;
+                return false;
             }
 
             // Acquiring culture-specific parsing info
@@ -586,6 +587,11 @@ public static ByteSize Parse(string s)
 
         public static ByteSize Parse(string s, IFormatProvider formatProvider)
         {
+            if (s == null)
+            {
+                throw new ArgumentNullException(nameof(s));
+            }
+
             if (TryParse(s, formatProvider, out var result))
             {
                 return result;