-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-1404: Support multiple import storages per provider #6216
Merged
triklozoid
merged 23 commits into
HumanSignal:develop
from
jpantzlaff:multiple-import-storage-for-provider
Oct 24, 2024
Merged
fix: LEAP-1404: Support multiple import storages per provider #6216
triklozoid
merged 23 commits into
HumanSignal:develop
from
jpantzlaff:multiple-import-storage-for-provider
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
@jpantzlaff Thank you for this great PR! Is it possible to add tests there? |
makseq
changed the title
fix: Support multiple import storages per provider
fix: LEAP-1404: Support multiple import storages per provider
Aug 26, 2024
@makseq Sorry for the delay, I got pulled into other work. Should be ready to review now. I had to update quite a few existing test assertions, just to make the bucket/container names match the existing mocks. |
triklozoid
approved these changes
Oct 24, 2024
poffdeluxe
added a commit
to theteamatx/3p-label-studio
that referenced
this pull request
Oct 29, 2024
…HumanSignal#6216)" This reverts commit 52507c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
What does this fix?
Within a single project, if more than one import storage (i.e. bucket) is added for the same cloud provider (e.g. S3 or GCS), authentication errors can occur when requesting signed URLs.
What is the new behavior?
The bucket and prefix of the imported object are now considered when choosing which import storage to use for signing.
What is the current behavior?
The first import storage added is used for all presigning requests from that provider. In other words, bucket and prefix settings are not honored.
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
Not applicable
What feature flags were used to cover this change?
Not applicable
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)