Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1404: Support multiple import storages per provider #6216

Merged

Conversation

jpantzlaff
Copy link
Contributor

@jpantzlaff jpantzlaff commented Aug 16, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

What does this fix?

Within a single project, if more than one import storage (i.e. bucket) is added for the same cloud provider (e.g. S3 or GCS), authentication errors can occur when requesting signed URLs.

What is the new behavior?

The bucket and prefix of the imported object are now considered when choosing which import storage to use for signing.

What is the current behavior?

The first import storage added is used for all presigning requests from that provider. In other words, bucket and prefix settings are not honored.

What libraries were added/updated?

None

Does this change affect performance?

No

Does this change affect security?

No

What alternative approaches were there?

Not applicable

What feature flags were used to cover this change?

Not applicable

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Aug 16, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a471d49

Copy link

netlify bot commented Aug 16, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a471d49

@github-actions github-actions bot added the fix label Aug 16, 2024
@jpantzlaff jpantzlaff marked this pull request as draft August 16, 2024 21:29
@makseq
Copy link
Member

makseq commented Aug 26, 2024

@jpantzlaff Thank you for this great PR! Is it possible to add tests there?

@makseq makseq changed the title fix: Support multiple import storages per provider fix: LEAP-1404: Support multiple import storages per provider Aug 26, 2024
@jpantzlaff jpantzlaff marked this pull request as ready for review September 6, 2024 19:45
@jpantzlaff
Copy link
Contributor Author

@makseq Sorry for the delay, I got pulled into other work. Should be ready to review now. I had to update quite a few existing test assertions, just to make the bucket/container names match the existing mocks.

@triklozoid triklozoid merged commit 52507c2 into HumanSignal:develop Oct 24, 2024
32 of 33 checks passed
poffdeluxe added a commit to theteamatx/3p-label-studio that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants