Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-931: Remove Stale Feature Flag - ff_back_1614_rejecte… #6136

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jul 25, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing an stale ff_flag that is already stale for more than a month.

What does this fix?

Clean code

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 4e9d3cf
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66a2ded2da6abe000845beda

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 4e9d3cf
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66a2ded267e39c0008cbf832

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (1a69603) to head (4e9d3cf).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6136      +/-   ##
===========================================
+ Coverage    76.73%   76.77%   +0.03%     
===========================================
  Files          168      168              
  Lines        13628    13650      +22     
===========================================
+ Hits         10458    10480      +22     
  Misses        3170     3170              
Flag Coverage Δ
pytests 76.77% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing it is great but im confused why it was defined in LSO if it wasnt used here? or was the FF declaration just missed when originally removing the code that used it?

@luarmr
Copy link
Contributor Author

luarmr commented Jul 26, 2024

@yyassi-heartexI had the same question. I believe it was created here as well, just in case it will be used and it never did.

@luarmr luarmr merged commit 33b9aa6 into develop Jul 29, 2024
40 checks passed
@luarmr luarmr deleted the fb-optic-931/remove-stale branch July 29, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants