fix: LEAP-860: have GCS generate data URLs if presign is disabled #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5968 +/- ##
===========================================
- Coverage 76.06% 76.04% -0.02%
===========================================
Files 162 162
Lines 13469 13475 +6
===========================================
+ Hits 10245 10247 +2
- Misses 3224 3228 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jombooth
changed the title
makseq
approved these changes
Jun 12, 2024
hakan458
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make GCS behave the same way as S3 import storages, in that when presign isn't enabled for the storage, we return data URLs containing b64-encoded data instead of presigned URLs in task data.
We don't have any unit tests that simulate fetching real data from GCS and while this code should have them, setting up a mock GCS is too large to be in-scope for this task, so I've carefully verified the behavior locally instead.