-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LEAP-1119: Feature/gridview thumbnail #5769
feat: LEAP-1119: Feature/gridview thumbnail #5769
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
/jira create
|
…g is not consistent and it can create confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added to the PR unit tests, also I removed the feature about show thumbnails, we already have something similar to it on the list view that doesn't need add any tags on the config, you just need to add a new node on the data (e.g. thumb), enable this column on the columns dropdown, and change the view mode from str
to img
on the thumb column, overall it looks good, thanks for the contribution!
If you have a piece of document about that I'm very interessed. It can help when we have very high resolution images. Thanks ! |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
Describe the reason for change
When using multilayered images, the original behaviour was to create a src that separate each image by a ','.
This way, it's not displayable.

What does this fix?
It fixes an issue in the gridview when there is multiple layers image.




It's even possible to use a specific "thumbnail" field, that allows to add a specific thumbnail to be use.
If you want the thumbnail to be displayed in the column view, just declare it as an image in the taxonomy :
What is the new behavior?
There is two different new behaviors.
If a "thumbnail" is provided :
The advantage is the ability to use a thumbnail that has a lower resolution than the original image.
else:
We use the first image of the multilayer images.
What is the current behavior?
The current behavior is that in this case, images url are separated by a ',' in the image src.
What display nothing at all
Does this change affect performance?
It can improve the performance because thumbnail can be a lower resolution image.
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
GridView => Data Exploration