Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1019: Validation with Table tag fails on List values in task.data #5736

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Apr 17, 2024

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Import fails with values like task.data['table'] = ["test", "test2"] (list) when Table is used in label config. However, Table supports it.

What does this fix?

Just add 1 line to supported types.

@github-actions github-actions bot added the fix label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ec1a840
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/661f1c5dd9b9f400080d7265

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ec1a840
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/661f1c5dea13ba00086f4431

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.91%. Comparing base (5c191a2) to head (ec1a840).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5736      +/-   ##
===========================================
- Coverage    75.91%   75.91%   -0.01%     
===========================================
  Files          158      158              
  Lines        13343    13352       +9     
===========================================
+ Hits         10130    10136       +6     
- Misses        3213     3216       +3     
Flag Coverage Δ
pytests 75.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq merged commit 7a70a2e into develop Apr 17, 2024
37 of 38 checks passed
@makseq makseq deleted the fb-LEAP-1019 branch April 17, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants