Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-574: Inconsistent behavior on Create Annotations From Predictions #5631

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Mar 26, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

With the changes to ML Backends, the logic in the retrieval of model versions caused a workflow regression in DataManager. The reason was because the default value of a project model version is an empty string, and all subsequent checks on retrieval of the model versions were considering strictly None to represent the absence. This fix loosens the checks to look for falsey/truthy instead which fixes the observed regressions.

Which logical domain(s) does this change affect?

Predictions, ModelVersions, DataManager

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 841da3a
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6602e79c02fd7200099706ac

@github-actions github-actions bot added the fix label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 841da3a
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6602e79cd019c0000862f296

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (b3dd626) to head (841da3a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5631      +/-   ##
===========================================
+ Coverage    76.19%   76.25%   +0.06%     
===========================================
  Files          158      158              
  Lines        13328    13328              
===========================================
+ Hits         10155    10163       +8     
+ Misses        3173     3165       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@niklub niklub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but as suggested by codecov, there should be a test to cover the lines. Let's create a follow-up ticket for that purpose

@bmartel bmartel merged commit 9128f2a into develop Mar 26, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants