Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-665: Fix runtime crash by downgrading react #5449

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

nick-skriabin
Copy link
Member

We introduced a runtime error by upgrading React 17 -> 18. This PR fixes it by rolling back to React 17

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Some pages became unusable due to a runtime error.

What is the new behavior?

No more runtime error

What is the current behavior?

Runtime error occurs when accessing certain pages

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Whole LSO

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 2cfccf5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65c631a6fc6a3c0008607c17

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 2cfccf5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65c631a632f7fe00086ccbed

@github-actions github-actions bot added the fix label Feb 9, 2024
@nick-skriabin nick-skriabin changed the title fix: LEAP-640: Fix runtime crash by downgrading react fix: LEAP-665: Fix runtime crash by downgrading react Feb 9, 2024
@MihajloHoma
Copy link
Contributor

MihajloHoma commented Feb 9, 2024

/docker build

Workflow run
Error: failed to execute "build" command

@nick-skriabin nick-skriabin merged commit 3388ce6 into develop Feb 9, 2024
29 of 31 checks passed
@nick-skriabin nick-skriabin deleted the fb-leap-640/fix-runtime-crash branch February 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants