-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: LEAP-508: Add
noreferrer
to external links (#5632)
[According to MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#security_and_privacy), `noopener` is not required anymore, because it's implied automatically > setting target="_blank" implicitly provides the same protection as setting rel="noopener" However `rel="noreferrer"` is important to not reveal anything for 3rd parties. And there is a security issue because of this: https://github.com/HumanSignal/label-studio/security/code-scanning/769 This PR adds `noreferrer` to external links like slack, github or pypi. It doesn't add it to links to our documentation. Also it adds `target="_blank"` to external links that didn't have it. Changed links: - Menu bar — github, slack, pypi - Export modal — github, slack - Invite people — docs - Webhooks — docs - Errors about wrong resource in LSF — link to this resource #### Does this change affect security? Fixes https://github.com/HumanSignal/label-studio/security/code-scanning/769 #### What alternative approaches were there? [Add `noopener`](#5609) but that doesn't make it fully secure --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@users.noreply.github.com>
- Loading branch information
1 parent
29b1cd7
commit 1796c6e
Showing
13 changed files
with
31 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "Merge branch 'develop' into 'fb-LEAP-1004'", | ||
"commit": "2174366308f877c5eed33bb1ba03346e6eb8d76e", | ||
"date": "2024-04-16T12:46:28.000Z", | ||
"branch": "fb-LEAP-1004" | ||
"message": "Merge branch 'develop' into fb-leap-508/external-links", | ||
"commit": "48d99bd060d2d0438a5a37dbe846da184ba8c0fc", | ||
"date": "2024-04-18T12:29:53.000Z", | ||
"branch": "fb-leap-508/external-links" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "Merge branch 'develop' into 'fb-LEAP-1004'", | ||
"commit": "2174366308f877c5eed33bb1ba03346e6eb8d76e", | ||
"date": "2024-04-16T12:46:28.000Z", | ||
"branch": "fb-LEAP-1004" | ||
"message": "Merge branch 'develop' into fb-leap-508/external-links", | ||
"commit": "48d99bd060d2d0438a5a37dbe846da184ba8c0fc", | ||
"date": "2024-04-18T12:29:53.000Z", | ||
"branch": "fb-leap-508/external-links" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "Merge branch 'develop' into 'fb-LEAP-1004'", | ||
"commit": "2174366308f877c5eed33bb1ba03346e6eb8d76e", | ||
"date": "2024-04-16T12:46:28.000Z", | ||
"branch": "fb-LEAP-1004" | ||
"message": "Merge branch 'develop' into fb-leap-508/external-links", | ||
"commit": "48d99bd060d2d0438a5a37dbe846da184ba8c0fc", | ||
"date": "2024-04-18T12:29:53.000Z", | ||
"branch": "fb-leap-508/external-links" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters