Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1738: Aws_access_key_id is displayed in Evaluation results #282

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

matt-bernstein
Copy link
Contributor

@matt-bernstein matt-bernstein commented Dec 17, 2024

We were not flagging inputs as image URLs correctly when the tag name and variable name differed, leading to the text of the image URL being fed to the prompt. Fixed this while avoiding changing the LSE<->adala API; will refactor later when we've settled on a better idea of what we need for image inputs to avoid code duplication. Ideally we wouldn't need to know so much about the LSE data model here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (dc54ace) to head (829c9be).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
adala/skills/collection/label_studio.py 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   68.03%   67.86%   -0.17%     
==========================================
  Files          47       47              
  Lines        2515     2524       +9     
==========================================
+ Hits         1711     1713       +2     
- Misses        804      811       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft December 18, 2024 08:07
@matt-bernstein matt-bernstein marked this pull request as ready for review December 18, 2024 13:28
@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented Dec 18, 2024

/git merge master

Workflow run
Successfully merged: 1 file changed, 1 insertion(+), 1 deletion(-)

@matt-bernstein matt-bernstein merged commit 2fa3215 into master Dec 18, 2024
11 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1738 branch December 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants