Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1619: logging and graceful handling for memory leaks #253

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

matt-bernstein
Copy link
Contributor

set https://docs.celeryq.dev/en/v5.4.0/userguide/workers.html#max-memory-per-child-setting so that when a child process hits 1GB, which is about 60% of the total memory limit for the whole worker, it is gracefully restarted after the current task finishes. Plus some cleanup and logging.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.32%. Comparing base (0ac4d2e) to head (0f14e14).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
server/tasks/stream_inference.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   66.29%   66.32%   +0.03%     
==========================================
  Files          47       47              
  Lines        2436     2459      +23     
==========================================
+ Hits         1615     1631      +16     
- Misses        821      828       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@robot-ci-heartex robot-ci-heartex marked this pull request as draft November 16, 2024 09:05
@matt-bernstein matt-bernstein marked this pull request as ready for review November 18, 2024 15:34
@matt-bernstein matt-bernstein merged commit 521a1a4 into master Nov 18, 2024
14 of 17 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1619 branch November 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants