fix(api): add Boolean as an orderable property

HugoMendes98 · Sep 26, 2023 · e5784fa · e5784fa
1 parent ed80657
commit e5784fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/libs/common/src/dtos/find-query/find-query-order.dto.spec.ts b/libs/common/src/dtos/find-query/find-query-order.dto.spec.ts
@@ -29,6 +29,8 @@ describe("FindQueryOrderDto", () => {
 				type: () => String
 			})
 			public f!: string | null;
+			@DtoProperty()
+			public g!: boolean;
 		}
 
 		const FlatOrderDto = FindQueryOrderDtoOf(FlatDto);
@@ -38,7 +40,7 @@ describe("FindQueryOrderDto", () => {
 		it("should be valid", () => {
 			const orders: Array<InstanceType<typeof FlatOrderDto>> = [
 				{ a: "asc", b: "desc", c: "asc_nf", d: "desc_nf" },
-				{ e: "asc_nl", f: "desc_nl" },
+				{ e: "asc_nl", f: "desc_nl", g: "asc" },
 				{}
 			];
 

diff --git a/libs/common/src/dtos/find-query/find-query-order.dto.ts b/libs/common/src/dtos/find-query/find-query-order.dto.ts
@@ -39,7 +39,7 @@ export function FindQueryOrderDtoOf<T extends object>(dto: Type<T>): Type<Entity
 
 				// We suppose that Object is a union or a "bad" type definition
 				// undefined for null
-				if ([String, Date, Number, Object, undefined].includes(type as never)) {
+				if ([Boolean, String, Date, Number, Object, undefined].includes(type as never)) {
 					decorators.push(IsIn(OrderValues));
 				} else {
 					const nestedType = generateOrderClass(type);