feat: logger implementation for event feeder like cosmos icon eth substrate #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanithkk
suggested changes
May 3, 2024
event_feed/src/cosmos/feeder.rs
Outdated
| let events = chain_config | ||
| .event_filter | ||
| .split(',') | ||
| .map(|e| e.to_string()) | ||
| .filter(|e| !e.is_empty()) | ||
| .collect::<Vec<String>>(); | ||
| // let logger = CoreLogger::new(Some("./event-feed.log")); |
…ion-for-Event-Feeder-like-Cosmos-icon-eth-substrate
…ion-for-Event-Feeder-like-Cosmos-icon-eth-substrate
…ion-for-Event-Feeder-like-Cosmos-icon-eth-substrate
shanithkk
suggested changes
May 4, 2024
event_feed/src/eth/feeder.rs
Outdated
| @@ -83,6 +90,10 @@ impl EthFeed { | |||
| let tx_receipt = client.get_transaction_receipt(tx_hash).await; | |||
|
|
|||
| if let Ok(Some(tx_receipt)) = tx_receipt { | |||
| self.logger.info(&format!( | |||
| "Received trabsaction receipt for the tx_hash : {:?}", | |||
There was a problem hiding this comment.
Typographical error "transaction"
| @@ -28,7 +32,10 @@ async fn test_filter_events_argument_with_no_method() { | |||
| event_filter: "balances=Transfer;system".to_string(), | |||
| contract_filter: "".to_string(), | |||
| }; | |||
| let polkadot = PolkadotFeed::<PolkadotConfig>::new(config).await.unwrap(); | |||
| let logger = CoreLogger::new(Some("./event-feed.log")); | |||
There was a problem hiding this comment.
clear the created files after test
shanithkk
approved these changes
May 6, 2024
shanithkk
deleted the
AV-273-Logger-implementation-for-Event-Feeder-like-Cosmos-icon-eth-substrate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Logger implementation for the event feed
Please select the options that are relevant.
Checklist: