Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue invalid explorer url open when run dive on kurtosis cloud #353

Merged

Conversation

abhiyana
Copy link
Contributor

Description:

Commit Message

fix: fix issue invalid explorer url open when run dive on kurtosis cloud

see the guidelines for commit messages.

Changelog Entry

1: Explorer link will not open automatically when running dive on kurtosis cloud

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5237e35) 12.67% compared to head (52471c7) 12.40%.

Files Patch % Lines
cli/common/context.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   12.67%   12.40%   -0.27%     
==========================================
  Files          11       11              
  Lines        1152     1177      +25     
==========================================
  Hits          146      146              
- Misses        994     1019      +25     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shreyasbhat0 shreyasbhat0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyasbhat0 shreyasbhat0 merged commit 06d1540 into main Jan 31, 2024
6 checks passed
@shreyasbhat0 shreyasbhat0 deleted the DV-248-invalid-url-opens-when-explorer-is-true-in-config-244 branch January 31, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants