This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Accept a new option, formatFunction, that converts numbers to strings #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides the "format" option, providing increased flexibility, e.g. for applications that use locale-specific number formatting.
|
Very cool. lgtm. |
| else | ||
| @addSpacer valueDigit | ||
| else | ||
| wholePart = not @format.precision or not fractionalPart(value) or false |
There was a problem hiding this comment.
Would it not make sense to just make this the default formatFunction?
There was a problem hiding this comment.
Yes, I think that would make perfect sense, but always having a formatFunction would require some refactoring elsewhere. I don't know this codebase, so I wanted to submit a minimal patch.
marcneuwirth
added a commit
that referenced
this pull request
Jun 4, 2014
Accept a new option, formatFunction, that converts numbers to strings
|
Much obliged, Marc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new option overrides the
formatoption, providing increased flexibility, e.g. for applications that use locale-specific number formatting.formatFunctioncan be any map from numerical values to strings.