Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

UMD support #41

Merged
merged 1 commit into from
Dec 6, 2013
Merged

UMD support #41

merged 1 commit into from
Dec 6, 2013

Conversation

akre54
Copy link
Contributor

@akre54 akre54 commented Dec 6, 2013

Awesome plugin. It'd be great to have out-of-the-box support for commonJS and AMD so I don't have to rely on globals.

@adamschwartz
Copy link
Contributor

lgtm. @zackbloom?

@zackbloom
Copy link
Contributor

LGTM. Thanks @akre54!

zackbloom added a commit that referenced this pull request Dec 6, 2013
@zackbloom zackbloom merged commit 2c923ce into HubSpot:master Dec 6, 2013
@zackbloom
Copy link
Contributor

My one note is that Odometer doesn't really 'depend' on jQuery, it can just optionally augment it. I don't think there is a way to express that with requirejs though.

@adamschwartz
Copy link
Contributor

Good point.

@infacq
Copy link

infacq commented Jan 10, 2014

hi

how do use it with requirejs. Debug console throw an error when i use new Odometer. It says undefined

@akre54
Copy link
Contributor Author

akre54 commented Jan 27, 2014

@infacq as far as I can tell this hasn't been released as a tagged version yet, so unless you compile the odometer.coffee file to javascript from master yourself you still have to use the old shim config in requirejs.

@zackbloom @adamschwartz can we get a version bump / recompile?

adamschwartz added a commit that referenced this pull request Jan 27, 2014
@adamschwartz
Copy link
Contributor

@akre54
Copy link
Contributor Author

akre54 commented Jan 27, 2014

thanks :)

@infacq
Copy link

infacq commented Jan 28, 2014

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants