Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Fixed: AMD exporting issues #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed: AMD exporting issues #102

wants to merge 1 commit into from

Conversation

dkulichkin
Copy link

  1. When built as an npm module by webpack - gets exported by default as an AMD module, which gives error: "Uncaught Error: define cannot be used indirect" - changed commonJS schema to be first in the exporting format order
  2. Exporting as amd module does not check jquery's presence

@dkulichkin
Fixed AMD exporting issues:
c8e6a99 
- When built by webpack as an npm package - gets exported as an amd module and produces "define could not be used isolated", hence changed export priority to commonjs
- Exporting as amd module does not check jquery's presense
@dkulichkin dkulichkin mentioned this pull request Aug 14, 2015
Open
@rickihastings
Copy link

👍

@barinovos
Copy link

Guys, please, can you merge it to the master??
I really need to export it for using with webpack and Angular2

@zackbloom
Copy link
Contributor

I believe odometer.js is a built file, so this change would need to be made in odometer.coffee.

@pablodenadai
Copy link

@dkulichkin any chance you could make this change to .coffee instead? Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkulichkin @rickihastings @barinovos @zackbloom @pablodenadai