Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to project upload and watch commands #654

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

This makes a handful of small UX improvements to the project upload and watch commands.

Upload

  • Added a link to Projects UI for the newly created build
  • Indented the subbuild statuses so hierarchy is more clear
  • Added some lines to make it more closely match the initial mocks

Watch

  • Properly clean up staged build in more scenarios (including when the user closes the terminal tab)
  • Show the user a prompt to quit the watch process
  • Remove the word "staging" from all output because it is confusing to the users.

Screenshots

Updated watch output

image

Upload (building)

Screen Shot 2022-03-24 at 5 44 55 PM

Upload (deploying)

Screen Shot 2022-03-24 at 5 45 10 PM

Upload (done)

Screen Shot 2022-03-24 at 5 45 18 PM

TODO

Who to Notify

cc/ @gcorne @markhazlewood @kemmerle @m-roll

Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down the branch to test locally, and everything is working as expected! The code is also streamlined :shipit:

@brandenrodgers brandenrodgers merged commit a4125d7 into master Mar 31, 2022
@brandenrodgers brandenrodgers deleted the project-link-to-build-on-upload branch March 31, 2022 15:00
@gcorne
Copy link
Contributor

gcorne commented Apr 4, 2022

For links, I wonder if we should use the URL so that users can copy and paste. I think that will be more accessible in a range of terminals/shells. It also is useful when the command is being run in a headless environment. Something similar came up came up back in the day with personal access keys (see #444).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants