Project deploy changes #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthmatic
commented
Sep 21, 2021
packages/cli/lib/projects.js
Outdated
| @@ -232,11 +232,102 @@ const pollBuildStatus = async (accountId, name, buildId) => { | |||
| }); | |||
| }; | |||
|
|
|||
| const pollDeployStatus = async (accountId, name, deployId) => { | |||
There was a problem hiding this comment.
This is very similar to the build status polling logic. Will definitely DRY this up- time permitting, I'll do that in this PR
|
I haven't dug into this yet, but I wanted to mention that IMO it's OK to get this deploy work out without handling the " Update hs project upload to be aware of deployments" work. If you want you could handle that in a separate PR. |
|
Example of the manual deploy flow: Since the auto-deploy side of things is still in flight I'm going to get this in so that folks can test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
hs project deployfor new deploy serviceScreenshots
TODO
Who to Notify