Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating context passed for marketplace validation #527

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Updating context passed for marketplace validation #527

merged 3 commits into from
Jun 21, 2021

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

  • Making some updates to the context that we pass in the output of the marketplace validation command.
  • I updated the output in the CLI to make it a little easier to read.
  • I updated the copy of the commands to make them more actionable and more consistent with each other.

Screenshots

Updated CLI output
image

TODO

Who to Notify

cc/ @KatzMitch

@brandenrodgers
Copy link
Contributor Author

I updated the title of each grouped section in the CLI output to be bold.
image

@KatzMitch
Copy link
Contributor

I love this new formatting!

@PaulJKim
Copy link

This looks amazing! Thanks Branden!

miketalley
miketalley approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@miketalley miketalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, but definitely not a blocker. Code looks good!

packages/cli/lib/validators/logValidatorResults.js
}
groupedResults.forEach(results => {
logger.log(chalk.bold(`${results[0].validatorName} validation results:`));
logger.group();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/cli/lib/validators/marketplaceValidators/theme/ThemeConfigValidator.js Outdated Show resolved Hide resolved
@brandenrodgers brandenrodgers merged commit aa06098 into master Jun 21, 2021
@brandenrodgers brandenrodgers deleted the marketplace-theme-validators-5 branch June 21, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketalley miketalley miketalley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandenrodgers @KatzMitch @PaulJKim @miketalley