updated Autoupload plugin README to support Webpack 5 and fix --env vars #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
The setup for the latest version of
copy-webpack-pluginrequires paths to live inside of apatternsarray. Documentation here: https://www.npmjs.com/package/copy-webpack-pluginAlso, passing environment vars to webpack doesn't work with the dot notation. The script should be
webpack --watch --env account 123 --env autoupload. Documentation here: https://webpack.js.org/guides/environment-variables/As a side note, the Hubspot.config.yml file always provides the account so that part isn't really needed (might be better to manage that all in one place—can the autoupload option be moved there?)
Who to Notify
@TheWebTech