Upload .JSON files last #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcorne
reviewed
Apr 29, 2021
| @@ -40,12 +41,14 @@ function getFilesByType(files) { | |||
| cssAndJsFiles.push(file); | |||
| } else if (extension === 'html') { | |||
| templateFiles.push(file); | |||
| } else if (extension === 'json') { | |||
There was a problem hiding this comment.
I suspect that we want to be more specific here and match only theme.json, fields.json that is not inside *.module and serverless.json.
There was a problem hiding this comment.
On second thought, that looks to be covered by how module files are already uploaded after otherFiles. Might be good to add test coverage of this either way.
There was a problem hiding this comment.
Exactly, and I can't see a reason to treat *.functions files differently.
Adjusted test coverage to include json files
brandenrodgers
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Sorts out all JSON files except for files in modules and uploads them last
Fixes #129