remove to limit notifications to the most relevant #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksvirkou-hubspot
requested review from
atanasiuk-hubspot,
asalauyeu-hubspot and
tpeuneu-hubspot
|
I noticed that this is a public RP with a private link in the description |
tpeuneu-hubspot
approved these changes
Mar 26, 2021
anthmatic
reviewed
Mar 26, 2021
| @@ -71,7 +71,6 @@ async function downloadProject( | |||
| encoding: null, | |||
| headers: { ...DEFAULT_USER_AGENT_HEADERS }, | |||
| }); | |||
| logger.log('Completed project fetch.'); | |||
There was a problem hiding this comment.
It might be worth it to keep these and switch to the debug level (logger.debug) to aid in troubleshooting in the future
There was a problem hiding this comment.
I can't do it because I switch level on my local machine but it prints debug messages
gcorne
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove to limit notifications to the most relevant