Handle international characters in remote HS paths #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Using for instance
hs remove
with international characters like 'æøå' fails. ([ERROR] The delete of "Æøå" in account nnnnnnn was bad.
)The
fileMapper.deleteFile
method now properly uses encodeURIComponent.I haven't browsed the rest of the methods, but likely all of them should encode paths.
The initial commit was a silly attempt breaking all tests. Second commit is likely the right solution. (Did not find any "remove" tests) 😇
Screenshots
patched:
Who to Notify
🤷♂️