Serverless empathy fixes #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthmatic
reviewed
Feb 9, 2021
…will default to 200
kemmerle
reviewed
Feb 11, 2021
| @@ -5,7 +5,7 @@ const { | |||
| } = require('../lib/commonOpts'); | |||
| const list = require('./functions/list'); | |||
| const deploy = require('./functions/deploy'); | |||
| const test = require('./functions/test'); | |||
| const server = require('./functions/server'); | |||
There was a problem hiding this comment.
+1 for this change; it's much more intuitive.
kemmerle
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
@miketalley, these changes make sense to me. I think that they make the experience spinning up a server much more developer-friendly--I appreciate that we've added more logging when installing dependencies and that we've streamlined our error handling.
anthmatic
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This fixes several issues that were found during the empathy session on 2/3
Local Serverless Testing
hs functions testtohs functions server@abelbnpm installprocess will be logged and interrupt the process @brandenrodgersresIf astatusCodeis provided.envfile, but having specified secrets inserverless.jsonServerless Deploy
cdnUrlis provided @bkrainer @gkemp94