Add messaging to use new package #420
Conversation
packages/cms-cli/bin/cli.js
Outdated
| @@ -27,10 +28,16 @@ const listCommand = require('../commands/list'); | |||
| const openCommand = require('../commands/open'); | |||
| const mvCommand = require('../commands/mv'); | |||
|
|
|||
| // Point update-notifier towards @hubspot/cli | |||
| const pkg = { name: '@hubspot/cli', version }; | |||
There was a problem hiding this comment.
One thing I'm not clear on is if cms-cli version will continue to increment with cli? If so, we'll probably want to hard code this to a lower version number
There was a problem hiding this comment.
Plan is to continue using the same version scheme so that the tags / versions in the repo continue to be meaningful. We'll start with 3.0 for the @hubspot/cli release so that there is adequate space in the versioning scheme for @hubspot/cms-cli should a patch be needed.
packages/cms-cli/bin/cli.js
Outdated
| const notifier = updateNotifier({ pkg }); | ||
|
|
||
| notifier.notify({ | ||
| shouldNotifyInNpmScript: true, | ||
| message: | ||
| chalk.bold('The CMS CLI is now the HubSpot CLI') + | ||
| '\n\nTo upgrade, run:\n\nnpm uninstall -g @hubspot/cms-cli\nand npm install -g @hubspot/cli', |
There was a problem hiding this comment.
What if we adjust the logic such that we're detecting that this code is part of @hubspot/cms-cli so that we can merge the changes back into master so that the process of merging changes from cms-cli branch back into master is straightforward?
There was a problem hiding this comment.
That's a good point, updated
Description and Context
Steers
update-notifiertowards the new package@hubspot/cliand adds a custom message with upgrade instructions. Open to feedback on this.Screenshots