Fix filemanger fetch error #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcorne
reviewed
Nov 12, 2020
packages/cms-lib/fileManager.js
Outdated
| @@ -174,6 +154,19 @@ async function fetchAllPagedFiles(accountId, folderId, { includeArchived }) { | |||
| * @param {object} options | |||
| */ | |||
| async function fetchFolderContents(accountId, folder, dest, options) { | |||
| try { | |||
| await fs.ensureDir(dest); | |||
| logger.log('Wrote folder "%s"', dest); | |||
There was a problem hiding this comment.
Minor, but I think that this assumes that the folder needs to be created.
There was a problem hiding this comment.
Good point, I just removed for now since I directory creation is implied
drewjenkins
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
While tracking down another bug, I found that the filemanger fetch command was failing when fetching folders due to a change in #339 that moved the logic for creating writeStreams and it looks like I missed updating this command as well.