Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log tailing #379

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix log tailing #379

merged 2 commits into from
Nov 9, 2020

Conversation

anthmatic
Copy link
Contributor

@anthmatic anthmatic commented Nov 3, 2020 •
edited
Loading

Description and Context

Fixes #378
There were two issues preventing logs from displaying properly:

  1. The first call to get the latest log result was improperly returning the first result (API has been fixed)
  2. The paging after token was not getting passed while polling for results, which caused the first 5 results to return each time.

@anthmatic anthmatic marked this pull request as ready for review November 5, 2020 21:13
@anthmatic anthmatic merged commit 1e46dc5 into master Nov 9, 2020
@anthmatic anthmatic deleted the fix/issue-378 branch November 9, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcorne gcorne gcorne left review comments

@drewjenkins drewjenkins drewjenkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hs logs --follow not working as docuemnted
3 participants
@anthmatic @gcorne @drewjenkins