Add docs for upgrading from dropwizard-guice #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjball
reviewed
Nov 23, 2018
jhaber
reviewed
Nov 27, 2018
README.md
Outdated
| [Reasoning and potential workarounds here](https://github.com/HubSpot/dropwizard-guicier/issues/41). The workarounds are however, not recommended. | ||
|
|
||
| ### Explicit Bindings Required | ||
| All objects that you wish to inject must be explicitly bound. Just-in-time bindings are not supported by default. This is the case despite you enabling explicit binding in your own module. |
There was a problem hiding this comment.
This is the case despite you enabling explicit binding in your own module.
Not sure I follow, can you clarify this?
There was a problem hiding this comment.
The behavior that I saw was because the GuiceEnforcer is enabled by default, I didn't have to enable explicit bindings in my own project.
There was a problem hiding this comment.
Ah I see, did you mean: "This is the case despite you not enabling explicit binding in your own module."
There was a problem hiding this comment.
Yup! Sorry, I'll fix that. Wrote these docs in a hurry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought this would be useful since I've run into both of these issues.