Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to search through tasks table by request type #936

Merged
merged 2 commits into from
Mar 17, 2016
Merged

Add ability to search through tasks table by request type #936

merged 2 commits into from
Mar 17, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Mar 7, 2016

This will break bookmarks and other URLs into the task table.

@ssalinas
Copy link
Member

ssalinas commented Mar 7, 2016

Now that we are using the requestsTable/requestsFilter template both in requests and in tasks, can we move it up a directory, and maybe rename it to requestTypeFilter.hbs? Bit more descriptive, and moves it out of a folder specific to requests since it's now shared. Other than that looks good

@Calvinp
Copy link
Contributor Author

Calvinp commented Mar 7, 2016

@ssalinas Done

@ssalinas
Copy link
Member

LGTM

ssalinas added a commit that referenced this pull request Mar 17, 2016
@ssalinas
Merge pull request #936 from HubSpot/filter-tasks-based-on-request-type
aadb9ad 
Add ability to search through tasks table by request type
@ssalinas ssalinas merged commit aadb9ad into master Mar 17, 2016
@ssalinas ssalinas deleted the filter-tasks-based-on-request-type branch March 17, 2016 13:55
@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
@Calvinp Calvinp mentioned this pull request Apr 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Calvinp @ssalinas