add support for override defaults file #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (oldVal == null || oldVal.isNull()) { | ||
| to.put(newFieldName, newVal); | ||
| } else if (oldVal.isArray() && newVal.isArray()) { | ||
| ((ArrayNode) oldVal).addAll((ArrayNode) newVal); |
There was a problem hiding this comment.
For this use-case do you think the behavior should be to append or to overwrite?
There was a problem hiding this comment.
good eye -- probably overwrite
…tead of append arrays
hs-jenkins-bot
changed the title
tpetr
pushed a commit
that referenced
this pull request
Feb 8, 2016
add support for override defaults file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pulling in an additional Singularity configuration file which overrides values from the default one. This is useful if you need to lock down S3 / database / LDAP credentials but would like the other settings to have looser read/write permissions.