make files table in task view sortable #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssalinas Just tweaked an attr so we don't sort on the last column. |
|
Cool, thanks |
|
|
@tpetr believe I have fixed the odd sorting now, we had some odd stuff going on with data-value which is used by sortable. Probably due to an older way of doing sorting. Still need to fix the task refresh piece |
|
Actually, sort clearing on task refresh might be part of a larger problem, looks like sorts do that on all of our pages, not just here |
|
LGTM -- let's revisit the sort clearing on refresh in a separate PR |
tpetr
pushed a commit
that referenced
this pull request
Dec 18, 2015
make files table in task view sortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.