fix npe when check for exception cause #761

ssalinas · 2015-11-13T19:36:30Z

tpetr · 2015-11-13T19:38:44Z

SingularityService/src/main/java/com/hubspot/singularity/data/SandboxManager.java

@@ -99,7 +99,7 @@ public SlaveNotFoundException(Exception e) {
    } catch (ConnectException ce) {
      throw new SlaveNotFoundException(ce);
    } catch (Exception e) {
-      if (e.getCause().getClass() == ConnectException.class) {
+      if (e.getCause()!= null && e.getCause().getClass() == ConnectException.class) {


insane nitpick -- can you add a space before !==? might also be good to wrap the two equality checks in parens for readability

tpetr · 2015-11-13T19:41:08Z

👍

fix npe when check for exception cause

fix npe when check for exception cause

b1a7b85

ssalinas added the hs_staging label Nov 13, 2015

tpetr reviewed Nov 13, 2015
View reviewed changes

ssalinas added 2 commits November 13, 2015 14:39

need a space

de96a11

wrap in parens

51f760d

ssalinas added the hs_qa label Nov 16, 2015

tpetr added the hs_stable label Nov 17, 2015

tpetr added this to the 0.4.6 milestone Nov 17, 2015

tpetr pushed a commit that referenced this pull request Nov 17, 2015

Merge pull request #761 from HubSpot/sentry_npe

61d44ab

fix npe when check for exception cause

tpetr merged commit 61d44ab into master Nov 17, 2015

tpetr removed hs_qa labels Nov 17, 2015

tpetr deleted the sentry_npe branch November 17, 2015 20:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix npe when check for exception cause #761

fix npe when check for exception cause #761

ssalinas commented Nov 13, 2015

tpetr Nov 13, 2015

tpetr commented Nov 13, 2015

fix npe when check for exception cause #761

fix npe when check for exception cause #761

Conversation

ssalinas commented Nov 13, 2015

tpetr Nov 13, 2015

Choose a reason for hiding this comment

tpetr commented Nov 13, 2015