Add request and task links to breadcrumbs on tail view #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what do you think about this? In this way, we're consistent with the breadcrumbs in the task page. If we're smart about padding / margins i think it should be OK |
|
@tpetr Moved them to their own row to match the other pages.
|
tpetr
pushed a commit
that referenced
this pull request
Nov 3, 2015
Add request and task links to breadcrumbs on tail view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to discussion on where to place these links. Putting them on their own row above the breadcrumbs took up too much precious vertical space, and making the links their full names instead of Request and Task would end up pushing out any longer file names.