Truncate beginning of S3 log filenames #635
Conversation
| @@ -106,3 +106,6 @@ Handlebars.registerHelper 'usernameFromEmail', (email) -> | |||
|
|
|||
| Handlebars.registerHelper 'substituteTaskId', (value, taskId) -> | |||
| value.replace('$TASK_ID', taskId) | |||
|
|
|||
| Handlebars.registerHelper 'trimS3File', (filename) -> | |||
| return '...' + filename.substring(filename.indexOf("service.log")); | |||
There was a problem hiding this comment.
unfortunately the log name will not always be service.log. That is the default for the SingularityExecutor, but it could be anything for s3 logs. I might go more on the route of taking the taskId out of the name (since we are already on the task page) to make a name that is more readable and shorter without having to truncate
There was a problem hiding this comment.
I was afraid that was the case. This model doesn't include the task id but I should be able to add it in.
|
This looks good but to be fully complete, we should surface the |
tpetr
changed the title
tpetr
force-pushed
the
s3_log_truncation
branch
from
4d61622 to
0402529
Compare
Truncate beginning of S3 log filenames
Truncate the beginning of s3 log files to enable reading of useful information.